Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update k8s executor to follow specified routes when applying manifests #3817

Merged
merged 2 commits into from
Jul 25, 2022
Merged

Update k8s executor to follow specified routes when applying manifests #3817

merged 2 commits into from
Jul 25, 2022

Conversation

nghialv
Copy link
Member

@nghialv nghialv commented Jul 22, 2022

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

@pipecd-bot
Copy link
Collaborator

TODO

The following ISSUES will be created once got merged. If you want me to skip creating the issue, you can use /todo skip command.

Details

1. Add test for this applierGroup function.

pipecd/pkg/app/piped/executor/kubernetes/applier_group.go

Lines 70 to 73 in 3597e07

// TODO: Add test for this applierGroup function.
func (d applierGroup) Get(rk provider.ResourceKey) (provider.Applier, error) {
for _, r := range d.resourceRoutes {
if r.Match == nil {

This was created by todo plugin since "TODO:" was found in 3597e07 when #3817 was merged. cc: @nghialv.

@nghialv nghialv enabled auto-merge (squash) July 25, 2022 01:05
@khanhtc1202 khanhtc1202 mentioned this pull request Jul 25, 2022
Merged
khanhtc1202
khanhtc1202 approved these changes Jul 25, 2022
View reviewed changes
Copy link
Member

@khanhtc1202 khanhtc1202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here you go

@nghialv nghialv merged commit 9d47ffb into master Jul 25, 2022
@nghialv nghialv deleted the multi-providers branch July 25, 2022 06:09
@pipecd-bot pipecd-bot mentioned this pull request Jul 25, 2022
Closed
@github-actions github-actions bot mentioned this pull request Jul 25, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knanao knanao knanao approved these changes

@khanhtc1202 khanhtc1202 khanhtc1202 approved these changes

Assignees
No one assigned
Labels
area/go
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nghialv @pipecd-bot @khanhtc1202 @knanao